Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize Native Builds #52

Merged
merged 11 commits into from Oct 1, 2023
Merged

Finalize Native Builds #52

merged 11 commits into from Oct 1, 2023

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck commented Sep 30, 2023 •
edited

Break out the native and zipapp builds and properly builds the linux/osx binary

@Marshall-Hallenbeck Marshall-Hallenbeck marked this pull request as ready for review September 30, 2023 21:52
NeffIsBack
NeffIsBack approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍🏼

@Marshall-Hallenbeck Marshall-Hallenbeck merged commit 72e42e9 into main Oct 1, 2023
5 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the feature/linux_build branch October 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeffIsBack NeffIsBack NeffIsBack approved these changes

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Marshall-Hallenbeck @NeffIsBack