[nanodump] fix error with temporary path #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XiaoliChan <2209553467@qq.com>
XiaoliChan
requested review from
zblurx,
Marshall-Hallenbeck and
NeffIsBack
as code owners
Signed-off-by: XiaoliChan <2209553467@qq.com>
|
Thanks @XiaoliChan for the issue and the PR! As we saw together, it's better/cleaner to use os.path.join instead of concatenating string to build filepaths. Also I fixed an issue in pypykatz dependency import |
zblurx
approved these changes
Oct 12, 2023
This was referenced Oct 12, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix path error when missing "/"
