Improved async/await support Edit #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penrillian-chrisa
added a commit
that referenced
this pull request
Aug 27, 2013
Improved async/await support Edit
kind-serge
reviewed
Feb 6, 2017
|
|
||
| return JsonConvert.DeserializeObject<KinveyHandshakeResponse>(json); | ||
| return await JsonConvert.DeserializeObjectAsync<KinveyHandshakeResponse>(json).ConfigureAwait(false); |
There was a problem hiding this comment.
This is harmful for performance, synchronous version is preferable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am Semih Okur, a PhD student in the CS department at the University of Illinois. I'm currently doing research on asynchronous programming in phone applications. I developed a tool that automatically improves async/await usages by doing transformations.
The tool found some opportunities in your application. First, it added "ConfigureAwait(false)" to some await statements in order to decrease overhead of capturing the context because those methods do not require context (like updating UI).
Second, it added corresponding async calls of methods in JsonConvert class under "async" declared methods. For instance, it replaces "JsonConvert.DeserializeObject" with "JsonConvert.DeserializeObjectAsync".
Are you interested in merging this pull request? If not, please let me know why, and I'll try and improve the pull request with your comments in mind.
Thanks,
Semih