Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Gulp version to 3.9.1 in package.json #32

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

Fillej
Copy link
Contributor

@Fillej Fillej commented Feb 6, 2017

"npm install gulp" supports up to version 3.9.1 of gulp.

"npm install gulp" supports up to version 3.9.1 of gulp.
@teltploek
Copy link
Contributor

Hi @Fillej

Thank you for your contribution to the project.

To be able to secure traceability throughout the development process, we have decided early on, that we in this repository want to be able to provide a high level of insight into our decision making. This will not only improve the general quality of the product, but also make it easier to on-board contributors and secure momentum if everyone knows a bit about the context on the why's, how's and what's in the thought processes behind actions taken along the way.

Therefore we'll also be needing a description behind the motivation, or a user story, to understand the reason behind submitted pull requests. Could you please provide a bit of background information on the intend of this contribution?

Thank you very much.

/Brian

Copy link
Contributor

@istern istern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant find a gulp version 3.9.5 so i think it is imporatant we fix this. as fast as possible.

@teltploek
Copy link
Contributor

Oh now I understand. And you're right - there's no such version.

For some unknown reason @Hafeok changed it here:
e220e2e

I think we should just merge this right away.

@teltploek teltploek merged commit 7e40712 into PentiaLabs:master Feb 14, 2017
teltploek added a commit that referenced this pull request Feb 14, 2017
Scope: Version bump, dependencies.
@teltploek
Copy link
Contributor

Merged, tagged and published to npm as new patch, v1.0.8.

Thank you @Fillej for your contribution! 🦄 🇸🇪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants