port2core 🎉 #65
port2core 🎉 #65
Conversation
TerribleDev
force-pushed
the
port2core
branch
2 times, most recently
from
862a906
to
34a24e4
Compare
|
I'm assuming this makes #56 obsolete sorry :( |
|
btw I tried to make the changes minimal. We can add async overloads and what not later. One major change at a time! |
|
So I just realized the unit tests didn't compile because of the missing Configuration project. I see its 1 file that has an obsolete on it. Should we just kill it? For now I'll comment out the broken test file |
TerribleDev
force-pushed
the
port2core
branch
from
34a24e4
to
5b53b5d
Compare
|
also this is a lingering question: https://github.com/Pereingo/statsd-csharp-client/pull/65/files#diff-73c83093cf1ddb7823ddb3f7572110b9R41 |
There was a problem hiding this comment.
Thanks Tommy, mighty generous of you to do the PR!
Would you mind deleting the old IStopwatch.ElapsedMilliseconds() method which is causing some warnings on the build while you're in there? Another long ago obsoleted thing.
https://ci.appveyor.com/project/DarrellMozingo/statsd-csharp-client
Also how does the nuget package get generated w/the new core build system? Where does the information from the nuspec go (ie package name, description, etc)?
Thanks again!
| @@ -38,19 +38,20 @@ public void TearDownUdpListener() | |||
| // Stop listening for client requests. | |||
| tcpListener.Stop(); | |||
| } | |||
| //this test requires a listener for a tcp socket...is it really a unit test? | |||
There was a problem hiding this comment.
Nope - it's more integration. To be fair it never did say it was a unit test ;) We just lumped them all together.
| { | ||
| Assert.That(Naming.CurrentEnvironment,Is.EqualTo("environment")); | ||
| } | ||
| //namespace Tests |
There was a problem hiding this comment.
Was actually planning to remove this in a future version as it's been Obsolete for a while - seems as good a time as any if you wouldn't mind just deleting the tests too.
|
You place the nuspec info in the peoject.json file. I just realized I filled out the wrong file. So I will have to fix that, but it looks like this. https://github.com/Pereingo/statsd-csharp-client/pull/65/files#diff-30e4c60ec7fca7af35cd910663eb7df8R4 |
|
You run |
|
Ah, cool. So for in the And we'll get the same artefact output, right? |
|
@DarrellMozingo isn't that what I am already doing? |
|
Oh yea, I'm blind :P Can you add the |
|
So I'm really sick with the flu right now. I'll have to come back to this next week when I'm feeling better. |
|
No worries mate, hope you feel better. |
|
Will this make it out some time soon? We'd really like to be able to use this library in out new .net core apps. |
|
@dkhanaferov I'll make this happen very soon-ish. |
|
@DarrellMozingo ....done |
|
Thanks again @TerribleDev for the PR |
Port the main project to core. This still supports .net 3.5!!!
Convert unit tests to project.json format but maintain the same version of nunit/rinomocks (so obv the unit tests are still full framework bound).
also update appveyor accordingly, and set the proper package options in the project.json file since nuspec's dont really exist with project.json.
The one wildcard is I got rid of the Configuration project, and I'm not too sure what requires it, since I was able to compile without it.
if the configuration project is needed and has to be in the net35 nuget package just let me know.