Allow storage insecure connection #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .travis.yml # api/osb/osb_controller.go # test/osb_test/osb_test.go
# Conflicts: # storage/interfaces.go # storage/postgres/storage.go # storage/postgres/storage_test.go
Pull Request Test Coverage Report for Build 1384
💛 - Coveralls |
storage/interfaces.go
Outdated
| @@ -37,6 +37,7 @@ type Settings struct { | |||
| URI string | |||
| MigrationsURL string `mapstructure:"migrations_url"` | |||
| EncryptionKey string `mapstructure:"encryption_key"` | |||
| SkipSSL bool `mapstructure:"skip_ssl"` | |||
There was a problem hiding this comment.
how about naming it skip_ssl_validation so that we are consistent with the api skip ssl validation?
storage/interfaces.go
Outdated
| @@ -45,6 +46,7 @@ func DefaultSettings() *Settings { | |||
| URI: "", | |||
| MigrationsURL: fmt.Sprintf("file://%s/postgres/migrations", basepath), | |||
| EncryptionKey: "", | |||
| SkipSSL: false, | |||
There was a problem hiding this comment.
I know that this is the default value, but would it make sense to add it to application.yml like we did with the api.skip_ssl_validation so that developers are aware they can change it?
KirilKabakchiev
previously approved these changes
Nov 19, 2018
KirilKabakchiev
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to skip ssl check on storage connection