MNT: Added a board representation of the ChArUco board #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rampex1
force-pushed
the
board_representation
branch
from
abe7c3f
to
90b4b9a
Compare
Rampex1
force-pushed
the
board_representation
branch
from
90b4b9a
to
c1cb60d
Compare
vaughantnrc
reviewed
Jun 21, 2024
| self._board_marker_positions.append([x, y, z]) | ||
|
|
||
| def get_ids(self): | ||
| self._generate_board() |
There was a problem hiding this comment.
won't this get called every time you try to get ids or positions? Wouldn't it make more sense for this to be called from init?
There was a problem hiding this comment.
Just to elaborate, from what I see in _generate_board(), it looks like the id's and positions will have their elements added each call. So first call they will have size 40 (ok), but then second it will be 80, then third call will be 120, etc...
There was a problem hiding this comment.
Yes it does make more sense to put that in init. I will make those changes in my board_builder PR which I will do Monday, so feel free to close this one.
There was a problem hiding this comment.
Or Tuesday actually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a representation of the current board that we are using for "setting_reference" in board_builder as well as the calibrator.
Marker 0 is at the top left, origin is at the bottom left.
Positive x goes from left to right, positive y goes upwards, positive z goes out of the board.
The coordinate system has been set in such a way that makes the renderer more intuitive (a marker moving left will move left in the renderer).