Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Added a board representation of the ChArUco board #48

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/board_builder/structures/charuco_board.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
class CharucoBoard:
"""
Representation of the Charuco Board
Marker 0 is at the top left, origin is at the bottom left.
Positive x goes from left to right, positive y goes upwards, positive z goes out of the board
"""

_board_marker_ids = list[int]
_board_marker_positions = list[list[int]]

def __init__(self):
self._board_marker_ids = []
self._board_marker_positions = []

def _generate_board(self):
for i in range(40):
self._board_marker_ids.append(i)

for marker_id in self._board_marker_ids:
x_coords = [30.0, 70.0, 110.0, 150.0, 10.0, 50.0, 90.0, 130.0]
x = x_coords[marker_id % 8]
y = 190.0 - (marker_id // 4) * 20.0
z = 0.0
self._board_marker_positions.append([x, y, z])

def get_ids(self):
self._generate_board()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this get called every time you try to get ids or positions? Wouldn't it make more sense for this to be called from init?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to elaborate, from what I see in _generate_board(), it looks like the id's and positions will have their elements added each call. So first call they will have size 40 (ok), but then second it will be 80, then third call will be 120, etc...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does make more sense to put that in init. I will make those changes in my board_builder PR which I will do Monday, so feel free to close this one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or Tuesday actually

return self._board_marker_ids

def get_positions(self):
self._generate_board()
return self._board_marker_positions