-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 1.220 on tuesday, 2014-11-11 #92
Comments
And 1.219_001 is on CPAN for this. Summary: Details: |
The bleeding edge Github version on Marpa::R2 tests all OK. |
With respect to Perl-Critic/Perl-Critic#192 and Perl-Critic/Perl-Critic#390, this release does parse certain hash constructors better, but it still misses in some cases, like this: |
I can confirm that it fixes Perl-Critic/Perl-Critic#455 |
@jeffreykegler : Thanks. :) @thaljef : Can you give me a concrete failure example, i.e. code i can run and debug? I see that %{$a_hash_ref} parses as a cast, followed by a block containing a variable, which looks correct to me. What should it be instead? |
Isn't that an anonymous hash constructor instead of a block? |
I can also confirm that this fixes Perl-Critic/Perl-Critic#451 |
This script implies strongly to me that it is indeed a block:
Edit: Though amusingly Perl::Tidy gets a little confused by it. Editedit: And thanks for the confirmations, good to know. :) |
You're right, it is a block. One of my Perl::Critic test cases may be bogus. I'll investigate more tomorrow. |
Neat. Enlightenment all around. :D |
The title of this bug is "release 1.120" but did you mean 1.220? |
Doh, you're right. Early typo. :) |
This bug has been fixed via Perl-Critic/PPI#92
This is fixed in the next release of PPI via Perl-Critic/PPI#92
The parsing of hash constructors has been improved in PPI and this bug is now fixed via Perl-Critic/PPI#92.
This bug has been fixed via Perl-Critic/PPI#92
This is fixed in the next release of PPI via Perl-Critic/PPI#92
The parsing of hash constructors has been improved in PPI and this bug is now fixed via Perl-Critic/PPI#92.
@wchristian Perl-Critic is good to go with this release of PPI. Thanks for all your effort to keep this vital project moving forward. |
+1 on my PPI-using module still passing all tests. |
ok here :) $ cpanm https://cpan.metacpan.org/authors/id/M/MI/MITHALDU/PPI-1.219_001.tar.gz
--> Working on https://cpan.metacpan.org/authors/id/M/MI/MITHALDU/PPI-1.219_001.tar.gz
Fetching https://cpan.metacpan.org/authors/id/M/MI/MITHALDU/PPI-1.219_001.tar.gz ... OK
Configuring PPI-1.219_001 ... OK
Building and testing PPI-1.219_001 ... OK
Successfully installed PPI-1.219_001
1 distribution installed
$ prove -l
t/autoprereq.t .................. ok
t/scan-module.t ................. ok
t/scan_prereqs.t ................ ok
t/scanner-eval.t ................ ok
t/scanner-test_requires.t ....... ok
t/scanner-use_module.t .......... ok
t/scanner-useok.t ............... ok
t/scanner-version-assertions.t .. ok
All tests successful.
Files=8, Tests=558, 6 wallclock secs ( 0.17 usr 0.01 sys + 5.17 cusr 0.24 csys = 5.59 CPU)
Result: PASS
$ perl -v
This is perl 5, version 18, subversion 2 (v5.18.2) built for i686-linux-thread-multi |
I've been travelling and unable to chip in. Thank you, @wchristian , for your continuing efforts. |
@moregan Sure thing, you did plenty already. :) If you find a little time, it would help me if you could remove some of the merged branches from your repo. |
1.220 is on CPAN, now to close all the related issues. :) |
mainly a not for myself
The text was updated successfully, but these errors were encountered: