ProhibitMagicNumbers false positive with capture variables

[thaljef]

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=72980
Requested On: Mon Dec 05 11:03:37 2011
Requested By: EDAVIS@cpan.org

---

Test program:

$_ = 'xxxxxxxxxxxxxxxxxxxx';
/(.)(.)(.)(.)(.)(.)(.)(.)(.)(.)(.)(.)(.)/;
my $x = $13;
print $x;

Checking with --single-policy ValuesAndExpressions::ProhibitMagicNumbers
gives the message

3 is not one of the allowed literal values (0, 1, 2).

[thaljef]

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=72980
Comment On: 2011-12-06 02:17:48
Comment By: clonezone@cpan.org

---

PPI bug:

ppidump 'my $x = $13;'
PPI::Document
PPI::Statement::Variable
[ 1, 1, 1 ] PPI::Token::Word 'my'
[ 1, 4, 4 ] PPI::Token::Symbol '$x'
[ 1, 7, 7 ] PPI::Token::Operator '='
[ 1, 9, 9 ] PPI::Token::Magic '$1'
[ 1, 11, 11 ] PPI::Token::Number '3'
[ 1, 12, 12 ] PPI::Token::Structure ';'

[wchristian]

A fix for this has been released as a dev version to CPAN. Please test and give feedback here:

Perl-Critic/PPI#92

[thaljef]

This is fixed in Perl-Critic-1.123 via PPI-1.220

[epa]

Thanks perlcritic and PPI developers for fixing this.