Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid metadata (dynamic_config should be true) -- consider dzilifying #40

Open
karenetheridge opened this issue May 30, 2017 · 0 comments

Comments

@karenetheridge
Copy link

META.json says dynamic_config => 0, but right there in the Makefile.PL, prereqs get added conditionally for Net::DNS and MSWin32 stuff.

This is easy to manage with Dist::Zilla (I gather you are familiar with it):

... your preferred bundle stuff goes here ...

[DynamicPrereqs]
:version = 0.018
-delimiter = |
-body = |unless (eval 'require Net::DNS; 1;') {
-body = |  my $found_it;
-body = |  my $ns = 'nslookup';
-body = |  foreach my $path (File::Spec->path) {
-body = |    my $file = File::Spec->catfile($path, $ns);
-body = |    $found_it = "$file.exe" if is_os('MSWin32') and -x "$file.exe" and !-d _;
-body = |    $found_it = $file if -x $file and !-d _;
-body = |  }
-body = |  $need_net_dns = ! $found_it;
-body = |}
-body = |requires('Net::DNS' => '0') if $need_net_dns;
-body = |requires('IO::CaptureOutput' => '0') if !$need_net_dns and is_os('MSWin32', 'Cygwin');

yanick added a commit to yanick/Email-Valid that referenced this issue Sep 8, 2018
For Perl-Email-Project#40, as part of the PR CPAN Challenge
rjbs pushed a commit that referenced this issue May 29, 2022
For #40, as part of the PR CPAN Challenge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant