Fix regression with implicit minimum value and multiple requirements #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like a copy-and-paste issue since the existing tests are exactly the same as for an explicit minimum value in range.
The with_string_requirement method stopped processing multiple requirements when it encountered a missing operator (implicit minimum value), thus missing further requirements if they were specified. This manifested, for example, as test failures for Module::CPANfile: http://www.cpantesters.org/cpan/report/89100bda-f299-11ed-ba95-ac6e75fda020
Leont
approved these changes
May 19, 2023
|
This obviously breaks cpanfile and tools depending on it (cpanm, Carton, Carmel). Can you make a new release on CPAN with the fix? Thanks! |
|
2.143 has just been shipped with a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
with_string_requirementmethod stopped processing multiple requirements when it encountered a missing operator (implicit minimum value), thus missing further requirements if they were specified.This manifested, for example, as test failures for Module::CPANfile:
http://www.cpantesters.org/cpan/report/89100bda-f299-11ed-ba95-ac6e75fda020