Skip to content

Commit

Permalink
[PATCH] Make EU::MM use LD and OPTIMIZE in recursive Makefile.PL invo…
Browse files Browse the repository at this point in the history
…cations

In a directory hierarchy with Makefile.PL files in subdirectories,
command line arguments like
 perl Makefile.PL OPTIMIZE="-g -O0"
are not used in the generated subdirectory Makefiles.

This seems to be by design: there's a short list of variables
that are inherited, the rest are not taken into account at all.

Debian needs LD and OPTIMIZE for sane handling of security
related build flags, so add those to the whitelist.

Bug: http://rt.cpan.org/Public/Bug/Display.html?id=28632
Bug-Debian: http://bugs.debian.org/660195
Patch-Name: debian/makemaker-recursive.diff

Signed-off-by: Chris 'BinGOs' Williams <chris@bingosnet.co.uk>
  • Loading branch information
ntyni authored and bingos committed Jul 11, 2013
1 parent b75edff commit 98e8532
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/ExtUtils/MakeMaker.pm
Expand Up @@ -574,7 +574,7 @@ END
}
if ($self->{PARENT}) {
$self->{PARENT}->{CHILDREN}->{$newclass} = $self;
foreach my $opt (qw(POLLUTE PERL_CORE LINKTYPE)) {
foreach my $opt (qw(POLLUTE PERL_CORE LINKTYPE LD OPTIMIZE)) {
if (exists $self->{PARENT}->{$opt}
and not exists $self->{$opt})
{
Expand Down

0 comments on commit 98e8532

Please sign in to comment.