Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"xtest" target for Makefile #205

Open
karenetheridge opened this issue Feb 2, 2015 · 2 comments
Open

"xtest" target for Makefile #205

karenetheridge opened this issue Feb 2, 2015 · 2 comments
Labels

Comments

@karenetheridge
Copy link
Member

'make xtest' should be available through standard use of Makefile.PL.

IMO it's sufficient to just have it target "xt/*", but if we wanted to get fancy we could glob-expand that and then:

  • trim xt/author/ if not $ENV{AUTHOR_TESTING}
  • trim xt/release/ if not $ENV{RELEASE_TESTING}
  • trim xt/smoke/ if not $ENV{AUTOMATED_TESTING}
@Leont
Copy link
Member

Leont commented Feb 2, 2015

I would do that subtly different, but that's mostly bike-shedding:

  • run xt/*.t && xt/author/ if $ENV{AUTHOR_TESTING}
  • run xt/release/ if $ENV{RELEASE_TESTING}
  • run xt/smoke/ if $ENV{AUTOMATED_TESTING}

A far more interesting question: should make xtest also run t/. To me, it'd be fairly useless without that.

Actually, given the semantics I just proposed, a separate xtest target wouldn't be necessary. A make test that takes those variables into account would be enough.

Not that either behavior is particularly trivial to implement in a portable makefile :-/

@karenetheridge
Copy link
Member Author

I think 'make xtest' should always run xt/* (minus the special sub-directories) regardless of the environment, just as Dist::Zilla::Plugin::RunExtraTests does... just as mauve is a good colour for that bikeshed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants