Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having ExtUtils::MakeMaker maintain all rpath arguments it was given #439

Open
jkahrman opened this issue Mar 23, 2023 · 0 comments

Comments

@jkahrman
Copy link

ExtUtils::MakeMaker drops any rpath argument that isn't an existing directory. I found that this is too restrictive because:

  • the directory could be created after the Makefile is generated
  • rpaths can be the variables $ORIGIN on Linux or @rpath, @loader_path, or @executable_path on Mac
jkahrman added a commit to jkahrman/ExtUtils-MakeMaker that referenced this issue Mar 23, 2023
ExtUtils::MakeMaker previously dropped any rpath argument that isn't an existing directory. This is too restrictive because:
* the directory could be created after the Makefile is generated
* rpaths can be the variables $ORIGIN on Linux or @rpath, @loader_path, or @executable_path on Mac

Also, do a Makefile escape of any single '$' in the rpath value ($ -> $$). Since the rpath value may also be consumed in a test in Makefile.PL where it doesn't need to be escaped, it's inconvenient to unescape it there.

See Perl-Toolchain-Gang#439
jkahrman pushed a commit to jkahrman/ExtUtils-MakeMaker that referenced this issue Mar 23, 2023
ExtUtils::MakeMaker previously dropped any rpath argument that isn't an existing directory. This is too restrictive because:
* the directory could be created after the Makefile is generated
* rpaths can be the variables $ORIGIN on Linux or @rpath, @loader_path, or @executable_path on Mac

See Perl-Toolchain-Gang#439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant