Correct test description. #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the correct thing to do is to reverse the read only and write only checks, so that the rm_rf test description is correct. That's what this was originally intended to check (fa708b9), but it somehow got lost in the shuffle between EU::Command, EUMM, and blead. |
jkeenan
added a commit
to jkeenan/ExtUtils-MakeMaker
that referenced
this pull request
May 9, 2017
Per code review by haarg, the order of tests was wrong in the first place. Hence, correctly re-ordering them is a better repair. Perl-Toolchain-Gang#294 (review)
|
On 05/09/2017 03:35 AM, Graham Knop wrote:
I believe the correct thing to do is to reverse the read only and write
only checks, so that the rm_rf is test description is correct. That's
what this was originally intended to check (fa708b9
<fa708b9>),
but it somehow got lost in the shuffle between EU::Command, EUMM, and blead.
Done. Please re-review.
Thank you very much.
Jim Keenan
|
|
Could you squash these into a single commit? Other than that, looks good. |
Per code review by haarg, the order of tests was wrong in the first place. Hence, correctly re-ordering them is a better repair than changing one test's description. For: Perl-Toolchain-Gang#294
|
On 05/09/2017 10:18 AM, Graham Knop wrote:
Could you squash these into a single commit? Other than that, looks good.
Pushed.
|
|
If this pull request is satisfactory, I would request a merge into master and timely release of a new version of ExtUtils-MakeMaker to CPAN. I have to soon release a new version of File-Path. It's doing fine on CPANtesters, but there would be one failure in ExtUtils-MakeMaker's t/eu_command.t in the absence of a new release of the latter. Thank you very much. Jim Keenan |
haarg
approved these changes
May 10, 2017
ntyni
pushed a commit
to ntyni/perl5
that referenced
this pull request
Oct 14, 2017
Per code review by haarg, the order of tests was wrong in the first place. Hence, correctly re-ordering them is a better repair than changing one test's description. For: Perl-Toolchain-Gang/ExtUtils-MakeMaker#294 [Debian note: this is a prerequisite for the CVE-2017-6512 fix in File-Path] Bug: Perl-Toolchain-Gang/ExtUtils-MakeMaker#294 Patch-Name: fixes/extutils_file_path_compat.diff
metux
pushed a commit
to oss-qm/perl5
that referenced
this pull request
Apr 26, 2018
Per code review by haarg, the order of tests was wrong in the first place. Hence, correctly re-ordering them is a better repair than changing one test's description. For: Perl-Toolchain-Gang/ExtUtils-MakeMaker#294 [Debian note: this is a prerequisite for the CVE-2017-6512 fix in File-Path] Bug: Perl-Toolchain-Gang/ExtUtils-MakeMaker#294 Patch-Name: fixes/extutils_file_path_compat.diff
metux
pushed a commit
to oss-qm/perl5
that referenced
this pull request
Apr 26, 2018
Per code review by haarg, the order of tests was wrong in the first place. Hence, correctly re-ordering them is a better repair than changing one test's description. For: Perl-Toolchain-Gang/ExtUtils-MakeMaker#294 [Debian note: this is a prerequisite for the CVE-2017-6512 fix in File-Path, and was backported by Dominic Hargreaves] Bug: Perl-Toolchain-Gang/ExtUtils-MakeMaker#294 Patch-Name: fixes/extutils_file_path_compat.diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, 'testdir' is write-only (0200), not read-only.