Avoid mangling /bin non-perl shebangs on merged-/usr systems #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like a good idea to have tests for this? |
|
This seems awfully special-cased... That said I'm not sure the purpose of mangling non-perl shebangs to begin with... |
|
@mohawk2 the whole PATH-related bit of shebang rewriting is currently mostly untested, other than to check that it doesn't rewrite a non-existing non-perl interpreter. |
If the shebang is absolute and exists in PATH, but was not the first one found, leave it alone if it's actually the same file as first one. This avoids packages built on merged-/usr systems with /usr/bin before /bin in the path breaking when installed on systems without merged /usr. See e.g. https://bugs.debian.org/913637.
ilmari
force-pushed
the
shebang-usr-merge
branch
from
ccfb664
to
6b279de
Compare
|
@mohawk2 tests added |
|
Seen. They look great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the shebang is absolute and exists in PATH, but was not the first
one found, leave it alone if it's actually the same file as first one.
This avoids packages built on merged-/usr systems with /usr/bin before
/bin in the path breaking when installed on systems without merged
/usr. See e.g. https://bugs.debian.org/913637.