-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the failing dynamic vs static tests on Win32 in blead #369
Conversation
It would be good to get to the bottom of these test issues, rather than disabling them. |
I agree. However, RT-115321 has been open for 4 years now. Also to Quote @tonycoz:
This has been causing noise on the smokers and I agree with him that turning the test off for a truly corner case like this makes sense until someone comes back and says: |
I think it's understood well enough. It's the sort of thing that is not very portable, and arguably people shouldn't be doing this anyway (but probably someone does). That said, not passing through LINKTYPE may be a better solution. |
@Leont To move this forward, would you be up for providing the alternative pull request? OR: Can we merge this and you provide the alternative when it is available? |
Changing this is trivial, but I haven't figured out if anything would break. I can't think of anything, but this is MakeMaker we're talking about… |
And while it's critical, we also get feedback really fast when it breaks something. Given we've thought about it for 4 years. maybe the best option at this point is to try your suggestion and get feedback? |
I was going to respond with a similar question. Would it not be useful to put in the suggestion solution and try to receive feedback? |
Work around for Perl/perl5#17601
See also https://rt.cpan.org/Ticket/Display.html?id=115321
This mirror's @tonycoz 's merge to blead found here Perl/perl5#18157