Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for picking up the proverc file from environment #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Corion
Copy link

@Corion Corion commented Oct 31, 2021

This adds support to find the proverc in other locations that are
usually preferred over the home directory:

$ENV{XDG_CONFIG_HOME}, which is where the "new" place for
user config is under OpenDesktop

$ENV{HOME}, as not every OS/shell sets ~

$ENV{USERPROFILE} for Windows

~ for Unix(ish) OSes

Maybe in a second step it makes sense to optionally pass the
%ENV into ->process_args()

This adds support to find the proverc in other locations that are
usually preferred over the home directory:

$ENV{XDG_CONFIG_HOME}, which is where the "new" place for
user config is under OpenDesktop

$ENV{HOME}, as not every OS/shell sets ~

$ENV{USERPROFILE} for Windows

~ for Unix(ish) OSes

Maybe in a second step it makes sense to optionally pass the
%ENV into ->process_args()
@Leont
Copy link
Member

Leont commented Nov 2, 2021

The removal of that glob is definitely a bug, that '~' will no longer work. And actually, glob already handles HOME and USERPROFILE.

Adding XDG_CONFIG_HOME support makes enough sense to me, the rest doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants