Skip to content

Commit

Permalink
reduce stderr noise in build
Browse files Browse the repository at this point in the history
Ideally you should be able to do

    (Configure && make test) 2> /tmp/err

with /tmp/err being empty. This is not the case, and this commit
is a first step towards that goal.

The

    fprintf (stderr, "Sizeof time_t = %ld\n", sizeof (time_t));

in Configure appears to be just a debugging aid; it's also a copy of the
code in Porting/timecheck.c, which people can always run if need-be.

hints/linux.sh appears to be looking for symbols in libdb.so; if the
library is stripped, this produces to stderr:

    /bin/nm: /lib/libdb.so: no symbols

I've silenced it for now with a 2>/dev/null, but I'm not sure if the whole
test is flawed, since with no symbols, 'nm libdb.so | grep pthread' is a
no-op.

make_patchnum.pl, when running backticks, prints $? to stderr if it's
non-zero; since a similar print in the other branch is already commented
out, I assume its just left-over debugging.
  • Loading branch information
iabyn committed Dec 3, 2014
1 parent c6eacdc commit 31b42f2
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion Configure
Original file line number Diff line number Diff line change
Expand Up @@ -21448,7 +21448,6 @@ int check_min ()

int main (int argc, char *argv[])
{
fprintf (stderr, "Sizeof time_t = %ld\n", sizeof (time_t));
check_max ();
check_min ();
return (0);
Expand Down
2 changes: 1 addition & 1 deletion hints/linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ then
DBLIB="$DBDIR/libdb.so"
if [ -f $DBLIB ]
then
if ${nm:-nm} -u $DBLIB | grep pthread >/dev/null
if ${nm:-nm} -u $DBLIB 2>/dev/null | grep pthread >/dev/null
then
if ldd $DBLIB | grep pthread >/dev/null
then
Expand Down
2 changes: 1 addition & 1 deletion make_patchnum.pl
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ sub backtick {
} else {
my $result= `$subcd $command`;
$result="" if ! defined $result;
warn "$subcd $command: \$?=$?\n" if $?;
#warn "$subcd $command: \$?=$?\n" if $?;
print "#> $subcd $command ->\n $result\n" if !$? and $opt_v;
chomp $result;
return $result;
Expand Down

0 comments on commit 31b42f2

Please sign in to comment.