Skip to content

Commit

Permalink
Disable new //p tests
Browse files Browse the repository at this point in the history
The previous commit fixed a regression in 5.18.0:

    my $pat = qr/a/;
    'aaaa' =~ /$pat/gp or die;
    print "MATCH=[${^MATCH}]\n";

which printed 'a' in 5.16.0, and undef in 5.18.0.
5.18.0 only broke the /g behaviour; the non-/g variant was already broken
and the previous commit didn't fix that for maint.

The new tests are testing for the non-/g variant, which still fail, so
disable these tests.

(Getting it to capture under non-/g works in 5.19.2 due to a major
reorganisation of the pp_match/pp_subst/regexec() code, which isn't
suitable for backporting to maint-5.18.)
  • Loading branch information
iabyn committed Jul 30, 2013
1 parent f4194b2 commit 4d7b2f5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion t/re/reg_pmod.t
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ use warnings;
our @tests = (
# /p Pattern PRE MATCH POST
[ '/p', "345", "012-", "345", "-6789"],
[ '/$r/p',"345", "012-", "345", "-6789"],
# these not supported under 5.18.x
#[ '/$r/p',"345", "012-", "345", "-6789"],
[ '(?p)', "345", "012-", "345", "-6789"],
[ '(?p:)',"345", "012-", "345", "-6789"],
[ '', "(345)", undef, undef, undef ],
Expand Down

0 comments on commit 4d7b2f5

Please sign in to comment.