Skip to content

Commit

Permalink
perldelta.pod: Link PPC's
Browse files Browse the repository at this point in the history 
People might not get what PPC is.

Let's make them visible by linking to the Perl/PPCs repository's previewable markdown files.
  • Loading branch information
@rwp0 @rjbs
rwp0 authored and rjbs committed Jun 28, 2023
1 parent 5a1ba0d commit aa4b032
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pod/perldelta.pod
View file
Expand Up @@ -402,11 +402,11 @@ Added the C<is_tainted()> builtin function. [L<github #19854|https://github.com/

=item *

Added the C<export_lexically()> builtin function as per PPC 0020. [L<github #19895|https://github.com/Perl/perl5/issues/19895>]
Added the C<export_lexically()> builtin function as per L<PPC 0020|https://github.com/Perl/PPCs/blob/main/ppcs/ppc0020-lexical-export.md>. [L<github #19895|https://github.com/Perl/perl5/issues/19895>]

This comment has been minimized.

Sign in to view

Copy link
@rwp0

rwp0 Jun 28, 2023 •
edited

Author Contributor

Does anyone think the zeros here (eg. PPC 0020) should be removed when referring to PPC ID's? Ie. perhaps no need to zero pad the PPC titles in documentation text (for the ease of reading and pronunciation)?.
@rjbs @Grinnz @esabol

This comment has been minimized.

Sign in to view

Copy link
@esabol

esabol Jun 29, 2023

Contributor

If you look at, for example, https://github.com/Perl/PPCs/blob/main/ppcs/ppc0020-lexical-export.md, it says "ID: 0020" at the top, so leading zeroes are correct (and all the PPCs have IDs like that), and I would not change it here. If you're asking in the broader sense of removing the leading zeroes from PPC IDs everywhere, I don't feel strongly about it, but I would lean towards no change.

Aside: I think the [L<github #19895|...] on this line should be [L<GH #19895|...] though, but maybe the other PR deals with that?

This comment has been minimized.

Sign in to view

Copy link
@rwp0

rwp0 Jun 29, 2023 •
edited

Author Contributor

Yes, the ID are indeed zeroed, but verbal/written references to PPC's may omit that, I think.

Okay, we may keep it then if it matches the ID's.

And no, I didn't mean to change PPC ID's themselves.

Yeah the other commit should have changed that, since it added only PPC links.

=item *

Support for PPC 0018, C<use feature "module_true";> has been added to
Support for L<PPC 0018|https://github.com/Perl/PPCs/blob/main/ppcs/ppc0018-module-true.md>, C<use feature "module_true";> has been added to
the default feature bundle for v5.38 and later. It may also be used
explicitly. When enabled inside of a module the module does not need
to return true explicitly, and in fact the return will be forced to
Expand Down

0 comments on commit aa4b032

Please sign in to comment.