Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP::Tiny needs two modules for https support #17706

Merged
merged 1 commit into from Jul 17, 2020

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Apr 9, 2020

When running sync-with-cpan on a machine for the first time, internal
subroutine wget() was silently failing. After adding debugging code and
running through the debugger, the HTTP::Tiny mirror() method call
displayed this error message:

IO::Socket::SSL 1.42 must be installed for https support
Net::SSLeay 1.49 must be installed for https support

@jkeenan jkeenan requested a review from bingos April 9, 2020 21:07
@jkeenan jkeenan added affects-5.34 do not merge Don't merge this PR, at least for now Infrastructure Things needed to maintain Perl development labels Apr 9, 2020
@Grinnz
Copy link
Contributor

Grinnz commented Apr 9, 2020

They just need to be installed, not loaded, so does this help other than documenting the requirement?

@xenu
Copy link
Member

xenu commented Apr 9, 2020

It makes it fail loudly and early.

@Grinnz
Copy link
Contributor

Grinnz commented Apr 9, 2020

Ah I missed the problem that the response is not checked for any errors.

@Grinnz
Copy link
Contributor

Grinnz commented Apr 9, 2020

You may wish to consider error handling like this: https://metacpan.org/release/HTTP-Simple/source/lib/HTTP/Simple.pm#L81-83

@wwlwpd
Copy link

wwlwpd commented Jul 7, 2020

I see the installation of IO::Socket::SSL fail surprisingly often due to missing or not found openssl libraries. I don't think just requiring those modules is going to cut it for this, unless you want to make HTTP::Tiny dependent of the https only use case. (not all people need it).

@Grinnz
Copy link
Contributor

Grinnz commented Jul 7, 2020

This PR is not related to the dependencies of HTTP::Tiny itself but just the core developer process using it in this case.

@jkeenan jkeenan self-assigned this Jul 9, 2020
When running sync-with-cpan on a machine for the first time, internal
subroutine wget() was silently failing.  After adding debugging code and
running through the debugger, the HTTP::Tiny mirror() method call
displayed this error message:

  IO::Socket::SSL 1.42 must be installed for https support
  Net::SSLeay 1.49 must be installed for https support
@jkeenan jkeenan force-pushed the jkeenan/sync-with-cpan-prereqs branch from f57599e to 6cda84a Compare July 17, 2020 20:24
@jkeenan jkeenan removed the do not merge Don't merge this PR, at least for now label Jul 17, 2020
@jkeenan jkeenan marked this pull request as ready for review July 17, 2020 20:24
@jkeenan jkeenan merged commit 34c2009 into blead Jul 17, 2020
@jkeenan
Copy link
Contributor Author

jkeenan commented Jul 17, 2020

Merged in commit 34c2009. Closing.

@rjbs rjbs deleted the jkeenan/sync-with-cpan-prereqs branch May 8, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Things needed to maintain Perl development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants