-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan9/9front i386 build #17891
Plan9/9front i386 build #17891
Conversation
Okay, looks like Travis-CI is complaining because I didn't add myself as an author, I didn't update the number of files for the manifest, and didn't set fndvers to have an exec bit. Same issue appears with the Sanity Linux -Dusethreads check. Other than those three trivial test fixes, anything else? |
Tested and confirmed that this builds and runs on 32-bit 9front, though there are still some 64-bit issues that I've not yet resolved. |
Would you be able to set a smoker up? We can help with this if you can make such a system available. Without a smoker it is likely to get broken again in the future, and hence we don't generally put a lot of effort into architectures without smokers. |
Yes, I'd be able to, but most likely not immediately. Maybe by next week. Considering how long it's been broken, I don't see that Plan9 had any effort put into it for almost two decades. I'll let you know when I have it setup. |
No idea what kind of smoker infrastructure would be needed, but if the infrastructure supports it, we can hook something to sourcehut's test runners. (https://sourcehut.org/blog/2020-05-11-sourcehut-plus-plan-9/) |
Yep, that was my plan, @oridb ! I have an account on sourcehut, just haven't had time to set anything up. |
@unobe please rebase so we can merge |
@khwilliamson , I've resolved the conflicts. |
@unobe still some conflicts to resolve: |
@unobe I realized that this branch is hard to review, even in GitHub. Right now the branch looks like this, ideally we should not view the
Note: I also noticed that you are using a branch named thanks |
@atoomic , @khwilliamson : see branch 17891-rebase-20200803 : https://github.com/unobe/perl5/tree/17891-rebase-20200803 . I don't see an easy way to modify the branch for this pull request. I could open up another pull request and reference this one, if you prefer. |
@unobe the branch You are right, if you rename the branch this would be a new Pull Request. As there is a lot of history and exchange in this ticket. It would be painful to switch between two cases. What I would suggest is do a hard reset of your As the other alternate I think would be to open a new PR, let's avoid that for now. |
@atoomic : I just ran 'git push --force origin' for blead. |
@atoomic , could you please add a perldelta entry? |
Relates: #17891 Add perldelta entry for Plan9 and 9front.
@karenetheridge perl delta entry via 6206614 |
Perl building on Plan 9 has not been updated for two decades. In each release of Perl since then, the versions have been updated when in fact they should have been pulled from a variable. This pull request updates Plan 9 to build on 9front, a fork of Plan 9. The last binary distribution of Perl 5 for Plan 9 was done by Bell Labs more than a decade ago, with no instructions on updating the plan9/ directory. The plan9/ files before this pull request will not build on stock Plan 9 or on 9front, and the work done here will at least get a successful compilation of perl with some basic tests working. More work needs to be done but this is the first step and allows for easier upstreaming of changes by other Plan 9 developers to allow Perl to successfully build on different architectures, not just i386.
Some of the changes in this pull request are not ideal, but are practical given the brokenness of Perl 5 builds on Plan 9. For instance, you'll note that there is a patch file that are stored within this request: 9front.patch. Yet the alternative is worse: a bit-rotten plan9/ directory which will continue to be useful at all for anyone working on Plan 9. The plan is that by the time Perl 7 is released these shortcomings will be resolved.