t/op/taint.t: Avert uninitialized value warning #18116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the test of shmread, if $id is undefined after the attempted assignment by shmget(), we get the "# shmget failed" warning and, since nothing has been read into $rcvd, that variable remains undefined. If $rcvd is undefined it will never be string-equal to $sent, which means the 'skip' condition will be exercised. Commit 5624951 made this file run with warnings enabled, so now the lack of assignment to $rcvd generates an uninitialized value warning (observed in smoke-test reports on FreeBSD). This patch accounts for non-definition of $rcvd and prevents that warning from being emitted.
|
Isn't it easier to default |
atoomic
reviewed
Sep 14, 2020
t/op/taint.t
Outdated
| @@ -1565,7 +1565,7 @@ SKIP: { | |||
| } | |||
|
|
|||
| skip "SysV shared memory operation failed", 1 unless | |||
| $rcvd eq $sent; | |||
| ($rcvd // '') eq $sent; | |||
There was a problem hiding this comment.
this is correct, better read IMO like unless defined $rcvd && $rcvd eq $sent
setting $rcvd to an empty string will solve some issues but not all and is not a good solution
There was a problem hiding this comment.
this is correct, better read IMO like
unless defined $rcvd && $rcvd eq $sent
setting$rcvdto an empty string will solve some issues but not all and is not a good solution
Updated.
|
as |
atoomic
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test of shmread, if $id is undefined after the attempted
assignment by shmget(), we get the "# shmget failed" warning and, since
nothing has been read into $rcvd, that variable remains undefined. If
$rcvd is undefined it will never be string-equal to $sent, which
means the 'skip' condition will be exercised.
Commit 5624951 made this file run with warnings enabled, so now the
lack of assignment to $rcvd generates an uninitialized value warning
(observed in smoke-test reports on FreeBSD). This patch accounts for
non-definition of $rcvd and prevents that warning from being emitted.