Discourage @_ in signatured subroutine
#19346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
force-pushed
the
discourage-defav-in-sigsub
branch
4 times, most recently
from
fd78cb8
to
8236755
Compare
|
Maybe consider a squash & rebase, before merging this? |
leonerd
force-pushed
the
discourage-defav-in-sigsub
branch
from
c3a80df
to
8dca553
Compare
|
This is now rebased, but I don't think we should merge it yet until it's had some more review. |
atoomic
reviewed
Jan 21, 2022
atoomic
reviewed
Jan 21, 2022
atoomic
reviewed
Jan 21, 2022
atoomic
reviewed
Jan 21, 2022
atoomic
reviewed
Jan 21, 2022
leonerd
force-pushed
the
discourage-defav-in-sigsub
branch
2 times, most recently
from
118e703
to
49d74bb
Compare
atoomic
approved these changes
Jan 25, 2022
Using op_parent() for a better context message
Warn for both `goto &SUB` tailcalls and `&SUB` in perl4 style
…res inside signatured subs
…otice caller's args when caller is a signatured sub
leonerd
force-pushed
the
discourage-defav-in-sigsub
branch
from
49d74bb
to
2d0a1c6
Compare
|
Having discussed this with PSC, we've decided to make it an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No actual runtime behavioural change, but if we're intending to cause some change at some future version it would be useful to get this warning in anyway to help flush out code that would otherwise be affected by such a future change.