Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage @_ in signatured subroutine #19346

Closed
wants to merge 17 commits into from
Closed

Discourage @_ in signatured subroutine #19346

wants to merge 17 commits into from

Commits on Jan 25, 2022

  1. Define a CvSIGNATURE flag

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    618b3c2 View commit details
    Browse the repository at this point in the history

  2. Set the CvSIGNATURE flag on signatured subs

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    4c48f52 View commit details
    Browse the repository at this point in the history

  3. Add a new 'discouraged' warning category

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    a305d61 View commit details
    Browse the repository at this point in the history

  4. Print a discouragement warning on implicit use of @_ in shift/pop

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    5ab327b View commit details
    Browse the repository at this point in the history

  5. Also print on explicit @_ of any op 

    Using op_parent() for a better context message
    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    6dc2ee1 View commit details
    Browse the repository at this point in the history

  6. Add the new diagnostic warning messages to perldiag.pod

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    3af0495 View commit details
    Browse the repository at this point in the history

  7. Print discouragement warning on implicit @_ in entersub 

    Warn for both `goto &SUB` tailcalls and `&SUB` in perl4 style
    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    4f9de2c View commit details
    Browse the repository at this point in the history

  8. Remove TODO comment about putting macro in embed.fnc, since it isn't … 

    …necessary there
    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    8b8e4cc View commit details
    Browse the repository at this point in the history

  9. Put some wording into perlsub.pod about @_ being discouraged in signa… 

    …tured subs
    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    0a9a403 View commit details
    Browse the repository at this point in the history

  10. Ensure that warnings can be disabled by no-warnings

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    a108fc4 View commit details
    Browse the repository at this point in the history

  11. Quiet the warnings about @_ being discouraged during intentional unit… 

    … tests about it
    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    7ca1d66 View commit details
    Browse the repository at this point in the history

  12. Use OP_TYPE_IS() in op.c

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    27b54af View commit details
    Browse the repository at this point in the history

  13. Add some tests that @_ is still permitted inside non-signatured closu… 

    …res inside signatured subs
    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    495cf16 View commit details
    Browse the repository at this point in the history

  14. No need to check CvSIGNATURE() twice in Perl_ck_subr()

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    0a1fc13 View commit details
    Browse the repository at this point in the history

  15. Also warn about uses of @_ at runtime from inside eval() that would n… 

    …otice caller's args when caller is a signatured sub
    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    78e35db View commit details
    Browse the repository at this point in the history

  16. Move the 'no warnings discouraged' inside the eval scope

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    b98d9ae View commit details
    Browse the repository at this point in the history

  17. Better handling of &SUB so as not to warn on \&SUB

    @leonerd
    leonerd committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    2d0a1c6 View commit details
    Browse the repository at this point in the history