Merge branch 'review/hobbestigrou' into devel

lib/Dancer/Logger/File.pm

@@ -11,8 +11,9 @@ use IO::File;
 
 sub logdir {
     my $appdir = setting('appdir');
+    my $altpath = setting('log_path');
     my $logroot = $appdir || File::Spec->tmpdir();
-    return path($logroot, 'logs');
+    return ($altpath ? $altpath : path($logroot, 'logs'));
 }
 
 sub init {
@@ -72,7 +73,9 @@ file.
 =head2 logdir
 
 Returns the log directory, decided by "logs" either in "appdir" setting or in a
-temp directory.
+temp directory. It's also possible to specify a logs directory with the log_path option.
+
+  setting log_path => $dir;
 
 =head2 _log
 

t/11_logger/03_file.t

@@ -1,4 +1,4 @@
-use Test::More tests => 9, import => ['!pass'];
+use Test::More tests => 14, import => ['!pass'];
 
 use strict;
 use warnings;
@@ -27,5 +27,16 @@ ok($l->debug("Perl Dancer test message 2/4"), "debug works");
 ok($l->warning("Perl Dancer test message 3/4"), "warning works");
 ok($l->error("Perl Dancer test message 4/4"), "error works");
 
+#Create a new tmp directory to test log_path option
+my $dir2 = tempdir(CLEANUP => 1);
+setting log_path => $dir2;
+
+is(Dancer::Logger::File->logdir, $dir2, 
+    "logir is ok");
+
+ok($l->_log(debug => "Perl Dancer test message with log_path setting"), "_log works");
+ok($l->debug("Perl Dancer test message with log_path setting 2/4"), "debug works");
+ok($l->warning("Perl Dancer test message with log_path setting  3/4"), "warning works");
+ok($l->error("Perl Dancer test message with log_path setting 4/4"), "error works");
+
 $l->{fh}->close;
-File::Temp::cleanup();