Make messages from fatal warnings show up in the logs #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with the `warnings => 1` setting (as is the default for the development config), these fatal warnings cause an Error 500 to be returned but do not show up in the logger at all. This is less than helpful. This patch changes it so that the warnings show up in the logger.
|
Sorry, I (well, |
|
Nice fix thank you! This has always annoyed me but I never quite put my brain into gear that it could be fixed. |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with the
warnings => 1setting (as is thedefault for the development config), these fatal warnings
cause an Error 500 to be returned but do not show up in
the logger at all. This is less than helpful.
This patch changes it so that the warnings show up in the
logger.