Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify D2::Template::Simple's role in life #1619

Closed
wants to merge 2 commits into from

Conversation

cromedome
Copy link
Contributor

This is one thing to come out of #1615. Got me to thinking about why we have two template systems in core when we really want to steer devs to other template engines.

After talking with @SysPete and @veryrusty, it was decided we should update the pod here to clarify what role Dancer2::Template::Simple fills, and to consider splitting Dancer2::Template::Tiny to another distribution.

This is one thing to come out of Issue #1615 on GitHub. Got me to
thinking about why we have two template systems in core when we really
want to steer devs to other template engines.

After talking with SysPete and veryrusty, it was decided we should
update the pod here to clarify what role Dancer2::Template::Simple
fills, and to consider splitting Dancer2::Template::Tiny to another
distribution.
@cromedome cromedome added this to the May 2021 milestone May 8, 2021
@ghost
Copy link

ghost commented May 9, 2021

@cromedome This sounds very good! I did some work in #1616 to try and remove Template::Simple, but I keep running in to issues with generating a new application and using Template::Tiny to create the config and app.psgi files from skeleton.
It is probably a better way forward to clarify the docs and the try removing the forked version of Template::Tiny instead.

Copy link
Member

@bigpresh bigpresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - although I think yanking it out of core entirely into its own CPAN dist might not be a bad thing. D1 users migrating to D2 who used to use Dancer::Template::Simple would have to then go install it, but I don't think many D1 users used D::T::Simple - I think many would have switched it out for a more full-featured engine, and as long as we document clearly on the migration doco that you'll need to install it if your app used D::T::Simple, that sounds fair to me.

@cromedome cromedome closed this May 16, 2021
@cromedome cromedome deleted the docs/template-simple branch May 16, 2021 19:18
@cromedome
Copy link
Contributor Author

Merged, thanks!

cromedome added a commit that referenced this pull request Jun 3, 2021
    [ BUG FIXES ]
    * GH #1611: Redirect '/' doesn't always work as expected (Russell
      @veryrusty Jenkins, Christopher Gurnee)
    * PR #1620: Quiet spammy failing CI builds (Jason A. Crome)
    * PR #1623: Copy Dockerfile from the right spot (Jason A. Crome)

    [ ENHANCEMENTS ]
    * PR #1613: Add git features to Dancer2 CLI (Jason A. Crome)
    * PR #1614: Generate Dockerfile when creating new app (Jason A. Crome)

    [ DOCUMENTATION ]
    * PR #1563: Fix typos in perlcritic.rc notes (Achyut Kumar Panda)
    * PR #1609: Document and test for missing DSL keywords (racke, Jason A.
      Crome)
    * PR #1618: Provide a consistent list of community resources (Jason A.
      Crome)
    * PR #1619: Clarify Dancer2::Template::Simple's role in life (Jason A.
      Crome)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants