Make template keyword global (GH #1159): #1163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the `template` keyword is available outside the request process. The request object (including the parameters and variables) will not be available during that `template` call.
Sessions are lazy, however we instantiate them before rendering a template within a request. When using `template` as a global keyword, we need to check that a request exists *AND* a sesison exists (for the request).
veryrusty
force-pushed
the
feature/global-template-keyword
branch
from
f24c486
to
3ad59bb
Compare
|
Added test case and predicate checks for a request before calling ( Session objects are lazy; when a request exists we inflate the session object before rendering a template if the route code didn't require the session be instantiated. ) |
|
@girlwithglasses what do you think? |
|
Looks great to me -- thank you! |
|
Should we merge this too? |
|
Would be nice to get one more thumbup. Pinging @racke, @SysPete or @cromedome for review |
|
👍 looks good to me. Change is small and there are people out there who want this. |
|
Thanks everyone. Merged as 5d3cdca. 👯 |
xsawyerx
added a commit
that referenced
this pull request
May 27, 2016
[ BUG FIXES ]
* GH #1165, #1167: Copy is_behind_proxy attribute into new request
on forward. (Russell Jenkins)
[ ENHANCEMENTS ]
* GH #1120: Move from MooX::Types::MooseLike to Type::Tiny for
performance. (Peter Mottram)
* GH #1145, #1164: Replace Class::Load with Module::Runtime
(Sawyer X)
* GH #1159, #1163: Make template keyword global.
(Sawyer X, Russell Jenkins)
[ DOCUMENTATION ]
* GH #1158: List both static and shared modules in Apache's deploy
instructions. (Varadinsky)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the
templatekeyword is available outside the request process. The request object (including the parameters and variables) will not be available during thattemplatecall.