Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PER-8255: Change error message #90

Merged
merged 1 commit into from
Feb 14, 2022
Merged

PER-8255: Change error message #90

merged 1 commit into from
Feb 14, 2022

Conversation

cecilia-donnelly
Copy link
Member

We use "connection error" as our default error message, which is
confusing to users. Change the name of the variable to better reflect
the problem and the message to users similarly.

We use "connection error" as our default error message, which is
confusing to users.  Change the name of the variable to better reflect
the problem and the message to users similarly.
Copy link
Member

@meisekimiu meisekimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The JIRA ticket doesn't explain very much so please correct me here, but the idea is to show this message even when a connection error occurs, right? Otherwise, do we still want to keep the ConnectionError value in the UploadSessionStatus enum along with its error message?

@cecilia-donnelly
Copy link
Member Author

Yes, since the only specific error we look for is the out of storage error in upload.session.ts, right? I didn't see anywhere that we differentiate between a connection error and any other error (e.g. a zero byte file being uploaded, which is how I tested this). If I missed it, though, then I can definitely change this.

I originally opened the ticket in response to a concern from the experience side that users would see "connection error" and try to fix their connection (reasonable!) even though really something else was going on that made a file fail.

@cecilia-donnelly cecilia-donnelly merged commit 9fb40a8 into main Feb 14, 2022
@cecilia-donnelly cecilia-donnelly deleted the PER-8255-error branch February 14, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants