Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PER-8255: Change error message #90

Merged
merged 1 commit into from
Feb 14, 2022
Merged

PER-8255: Change error message #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/core/components/upload-progress/upload-progress.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
<strong>{{fileCount.completed}}</strong> of <strong>{{fileCount.total}}</strong>files uploaded
</div>
</div>
<div *ngIf="status === UploadSessionStatus.ConnectionError" class="upload">
<div *ngIf="status === UploadSessionStatus.DefaultError" class="upload">
<div class="message">
<strong>
Connection error
Oops, something went wrong!
</strong>
<br>
<span *ngIf="fileCount.completed">{{fileCount.completed}} uploaded, </span>
Expand Down
2 changes: 1 addition & 1 deletion src/app/core/components/upload-progress/upload-progress.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class UploadProgressComponent {
case UploadSessionStatus.Done:
this.upload.dismissProgress();
break;
case UploadSessionStatus.ConnectionError:
case UploadSessionStatus.DefaultError:
this.upload.dismissProgress();
break;
case UploadSessionStatus.StorageError:
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/services/upload/upload.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ export class UploadService implements HasSubscriptions, OnDestroy {
case UploadSessionStatus.Done:
this.accountService.refreshAccountDebounced();
break;
case UploadSessionStatus.ConnectionError:
this.message.showError('Unable to connect - try again in a moment');
case UploadSessionStatus.DefaultError:
this.message.showError('Oops, something went wrong! Please try again. If the issue persists, reach out to us at support@permanent.org.');
this.accountService.refreshAccountDebounced();
break;
case UploadSessionStatus.StorageError:
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/services/upload/upload.session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export enum UploadSessionStatus {
Start,
InProgress,
Done,
ConnectionError,
DefaultError,
StorageError,
}

Expand Down Expand Up @@ -124,7 +124,7 @@ export class UploadSession {
);
} else {
this.emitError(
UploadSessionStatus.ConnectionError,
UploadSessionStatus.DefaultError,
item,
);
}
Expand Down