(phi0690)-phi0690.phi001-phi0690.phi003.perseus-eng2/lat2_cts.xml #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcerrato
requested changes
Jun 3, 2021
| @@ -36,18 +35,15 @@ | |||
| <biblStruct> | |||
| <monogr> | |||
| <author>Vergil</author> | |||
| <author>Virgil</author> | |||
| <title>The Bucolics, Aeneid, and Georgics Of Virgil</title> | |||
| <editor role="editor">J. B. Greenough</editor> | |||
There was a problem hiding this comment.
<editor role="editor"> s/b <editor>
There was a problem hiding this comment.
I'm not quite sure what you mean by s/b @lcerrato sorry if I am missing the obvious.
There was a problem hiding this comment.
So its ok that I took out the role="editor" right that's what I have been doing.
| <respStmt> | ||
| <name>Theodore C. Williams</name> | ||
| <resp>trans.</resp> | ||
| <resp>translator</resp> |
There was a problem hiding this comment.
Probably preferable practice to use <editor role="translator"> given what Eldarion is doing with <respStmt> tags
AlisonBabeu
changed the title
lcerrato
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected _cts.xml for phi0690.phi003.perseus-eng2 also updated the file header to current standards.
Updated headers for both phi0690.phi003.perseus-lat2 and perseus-eng2
Fix #430
Per issue #431.