Fix PHA resource id computation #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4x3rotab
requested changes
Jan 20, 2022
scripts/js/xtransfer.js
Outdated
| @@ -273,14 +271,14 @@ function dumpResourceId(khalaApi, soloChainId) { | |||
|
|
|||
| async function main() { | |||
| // create khala api | |||
| const khalaEndpoint = process.env.ENDPOINT || 'ws://localhost:9944'; | |||
| const khalaEndpoint = process.env.ENDPOINT || 'ws://35.215.162.102:9944'; | |||
There was a problem hiding this comment.
No, don't submit the real IP to the repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we set a constant resource id for PHA, that because it just need match the rid configed in Ethereum,
now different solo chain have different resource id, even though they are both indicate PHA. So there is no need
store resource id in pallet-bridge any more, instead we compute it dynamically during transfer.
Dispatch
set_resourceand other resource setting relevant methods are removed too, including ChainBridge relayer side.Fix PHA resource id computation in
BridgeTransfer.transferandXcmTransactor.deposit_assetwhich would case PHA transfer with other solo chains except Ethereum(with chain id 0) failure.