Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StakePool and Vault improvements #1420

Merged
merged 7 commits into from Oct 27, 2023
Merged

StakePool and Vault improvements #1420

merged 7 commits into from Oct 27, 2023

Conversation

h4x3rotab
Copy link
Contributor

@h4x3rotab h4x3rotab commented Oct 22, 2023 •
edited

A few security and accounting improvements:

  • Allow a vault force withdraw requests to be partially filled whenever there's available stake in stake pool by calling check_and_maybe_force_withdraw
  • Trigger fall safe vault force withdraw when there's a request with 3x grace period (21 days)
  • Trigger vault owner reward settle at the beginning of contribute() and withdraw()
  • Add precise burnt shares to the Withdrawal event
  • Add withdrawing NFT id to the WithdrawalQueued event

@h4x3rotab
compute: emit nft id in WithdrawalQueued
0b84377
@h4x3rotab
compute: add burnt shares to withdrawal event
1dcba08 
Also rewrite withdraw tests
@h4x3rotab
cargo fmt
26fd290
@h4x3rotab
compute: improve vault force withdraw
24c0ad5 
- Add ForceShutdown event with shutdown reason
- Allow partial fill of force withdraw
- Fallsafe shutdown for withdrawal > 3x grace period
@h4x3rotab
cargo fmt
ec514b2
@h4x3rotab
compute: settle vault reward when necessary
f862904
@h4x3rotab h4x3rotab merged commit 3252430 into master Oct 27, 2023
7 of 8 checks passed
@h4x3rotab h4x3rotab deleted the vault-delay-withdraw branch October 27, 2023 11:49
@h4x3rotab h4x3rotab mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@h4x3rotab