Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Geolocation Probing refactoring #498

Closed
wants to merge 63 commits into from
Closed

Simple Geolocation Probing refactoring #498

wants to merge 63 commits into from

Conversation

Soptq
Copy link
Contributor

@Soptq Soptq commented Sep 24, 2021 •
edited
Loading

  1. Add geocoding TTL at contract level.
  2. Moving probing to pruntime with sidetask and secure message channel.
  3. Refactor the geolocation contract for readability.
  4. Add on_block_end callback to contracts.

Note that currently geolocation probing is disabled by default in this PR. To enable it, you need to add a --enable_geoprobing flag to pruntime app:

./app --enable_geoprobing

h4x3rotab
h4x3rotab reviewed Sep 26, 2021
View reviewed changes
Copy link
Contributor

@h4x3rotab h4x3rotab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to run cargo fmt on your changed directories. (Don't include the changes it makes on the file you didn't touch)

crates/phactory/src/prpc_service.rs Outdated Show resolved Hide resolved
crates/phactory/src/prpc_service.rs Outdated Show resolved Hide resolved
crates/phactory/src/contracts/geolocation.rs Outdated Show resolved Hide resolved
crates/phala-types/src/lib.rs Outdated Show resolved Hide resolved
crates/phactory/src/system/side_tasks/geo_probe.rs Outdated Show resolved Hide resolved
crates/phactory/src/contracts/geolocation.rs Outdated Show resolved Hide resolved
crates/phactory/src/contracts/geolocation.rs Outdated Show resolved Hide resolved
crates/phactory/src/contracts/geolocation.rs Outdated Show resolved Hide resolved
crates/phactory/src/contracts/geolocation.rs Outdated Show resolved Hide resolved
crates/phactory/src/system/side_tasks/geo_probe.rs Outdated Show resolved Hide resolved
@Soptq Soptq marked this pull request as draft September 27, 2021 08:23
@Soptq Soptq mentioned this pull request Sep 27, 2021
Merged
@Soptq Soptq marked this pull request as ready for review September 27, 2021 13:14
@Soptq
Copy link
Contributor Author

Soptq commented Sep 27, 2021

@h4x3rotab Done. Currently build checks will fail because the upstream PR has not been merged yet.
Phala-Network/prpc-protos#7.

Soptq and others added 24 commits September 29, 2021 18:49
@Soptq
gracefully handle mmdb not found exception
4efe271
@Soptq
purging expired region map based on ttl
754bfab
@Soptq
fix bugs
c2fe421
@Soptq
fix e2e test error (mmdb database not exists).
9abdfbb
@Soptq
open fstat64 in libc_hacks.rs
3eeea41
@Soptq
fix fstat64 compiling error
36b4dd0
@Soptq
optimize info log display, show contract topic
95db545
@Soptq
add a configurable flag to pruntime to enable geolocation probing.
b904608
@Soptq
add a new flag geoip_city_db to pruntime.
728ceb6
@Soptq
fix error handles in geolocation.rs and geo_probe.rs
2737439
@Soptq
fix ld fstat64 undefined error
b8c848c
@Soptq
code fmt
1f622e5
@Soptq
gracefully handle errors in db_query_region_name fn
1ab3c19
@Soptq
contracts: add on_block_end callback to contracts
f69fb9c
@Soptq
contracts: make existed contracts compatible with on_block_end call…
24fc636 
…back
@Soptq
enable load balance in the geo_probe side task
97df80e
@Soptq
remove depreciated rpc
a4baff6
@Soptq
enable close() in libc_hacks.rs
fc14a9f
@Soptq
contracts: add default on_block_end implementation in the trait.
d2f2b58
@Soptq
geoprobe: code refactoring
7cf09df
@Soptq
enable geolocation probing in fullstack.js test
c86f198
@Soptq
Merge branch 'dev-geo-probing-v2' of https://github.com/Soptq/phala-b…
6978ec8 
…lockchain into dev-geo-probing-v2
@Soptq
fix cargo
c44e9bb
@Soptq
update to the latest prpc
69b7bcd
@Soptq
Copy link
Contributor Author

Soptq commented Sep 29, 2021

Sorry I accidentally messed up this PR's commit history. Will create another PR instead.

@kvinwang kvinwang mentioned this pull request Sep 29, 2021
Merged
@Soptq Soptq mentioned this pull request Sep 29, 2021
Merged
@Soptq
Copy link
Contributor Author

Soptq commented Sep 29, 2021

#510

@h4x3rotab
Copy link
Contributor

Closing in favor of #510

@h4x3rotab h4x3rotab closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h4x3rotab h4x3rotab h4x3rotab left review comments

@kvinwang kvinwang Awaiting requested review from kvinwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Soptq @h4x3rotab @kvinwang