Fix #487: remove dust in stake & share calc #515

h4x3rotab · 2021-10-04T16:43:20Z

Fixes #487

Handle dust when calculating stake & shares in the following rules:
- Dust in user's locked stake will be removed by slash
- Dust in a user's share is removed, and always maintain the invariant: sum(user shares) == pool's total share
- Dust in a pool's total_stake is removed
- Dust in withdraw queue is removed
- Dust in payout report from GK is dismissed
Add a migration to remove all the existing dust in the storage
- Analyzed with try_runtime, and with state dumped for offline analysis

Tested

Unit test with grcov:

pallets/phala/src/stakepool/migrations.rs

pallets/phala/src/stakepool.rs

tolak · 2021-10-05T15:43:30Z

Except the function name is_positive_balance , others LGTM

h4x3rotab added 2 commits October 4, 2021 16:36

Fix #487: remove dust in stake & share calc

d1b0353

fix tab

7dc6136

h4x3rotab commented Oct 4, 2021

View reviewed changes

pallets/phala/src/stakepool/migrations.rs Outdated Show resolved Hide resolved

h4x3rotab added 4 commits October 5, 2021 03:08

typo

21f55d6

account weight in migration

37846c0

remove unused on-the-fly backfill code

468d32a

dissmiss dust payout and add comments

8f005c9

h4x3rotab requested review from jasl and tolak October 5, 2021 08:56

tolak reviewed Oct 5, 2021

View reviewed changes

pallets/phala/src/stakepool.rs Outdated Show resolved Hide resolved

s/is_positive_balance/is_nondust_balance/g

89316fe

h4x3rotab enabled auto-merge October 5, 2021 20:42

h4x3rotab merged commit d20ef35 into master Oct 5, 2021

h4x3rotab deleted the fix-487 branch October 5, 2021 21:44