Update PHANGS Cy1 to v1.1 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low-sky
approved these changes
Feb 8, 2024
thomaswilliamsastro
force-pushed
the
phangs-jwst-v1p1
branch
5 times, most recently
from
9a71b0b
to
5cb89bc
Compare
|
@low-sky there have been a number of updates here to try and fix some crashes, so this could do with another review. I'll let you know if it runs successfully, but there may also be some small changes to astrometry that I'll need to do some QA on |
thomaswilliamsastro
force-pushed
the
phangs-jwst-v1p1
branch
4 times, most recently
from
49f61e3
to
35ff103
Compare
thomaswilliamsastro
force-pushed
the
phangs-jwst-v1p1
branch
10 times, most recently
from
eae3fbf
to
b0cb6b3
Compare
- For lv1 background obs, just copy over the science if it already exists - Add BMAJ info into psf_matched data - Auto rotate WCS in level_match - Fix SIP approximation issue in apply_wcs_adjust - Fix bug in astrometric_align that has only become apparent with package updates - Add version pins to package requirements to avoid incompatibilities - Remove factor of 2 in tweakreg FWHM values for lv3 - Add starfind options to astrometric_catalog_step - Updated MIRI FWHM values - Updates to the Cy1 Treasury config
thomaswilliamsastro
force-pushed
the
phangs-jwst-v1p1
branch
from
b0cb6b3
to
ac6d633
Compare
|
@low-sky ready for review! |
low-sky
approved these changes
Mar 2, 2024
| @@ -180,4 +180,14 @@ def parallel_psf_match(self, current_task, current_band=None): | |||
| file, output_file, file_kernel=kernel_file, output_grid=output_grid | |||
| ) | |||
|
|
|||
| # Put in BMAJ header keywords for Gaussian convolves | |||
There was a problem hiding this comment.
Add BMIN = BMAJ and BPA=0.0 for full radio beam compliance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now since updating various packages might cause some issues
This PR bumps the PHANGS Cycle 1 config through to v1.1, which is now all observations complete (NGC4303/4321 have the last 2 NIRCam tiles now). They look good!