Add plane fitting to level_match_step.py #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticing some issues with NIRCam shorts. I'll poke into it |
thomaswilliamsastro
force-pushed
the
plane-fit-level-match
branch
from
2330cd8
to
8ea36ac
Compare
low-sky
approved these changes
May 9, 2024
thomaswilliamsastro
force-pushed
the
plane-fit-level-match
branch
from
8ea36ac
to
2919439
Compare
thomaswilliamsastro
force-pushed
the
plane-fit-level-match
branch
from
2919439
to
013966a
Compare
- Also adds in metadata about background offset times at the lv2 stage - Also adds in option to combine the NIRCam short chips before any mosaic level matching - Fixes bugs - Updates various package versions
thomaswilliamsastro
force-pushed
the
plane-fit-level-match
branch
from
013966a
to
275355c
Compare
low-sky
reviewed
Jun 18, 2024
| "lmfit>=1.2.2", | ||
| "matplotlib>=3.8.2", | ||
| "numpy>=1.26.4", | ||
| "numpy>=1.26.4,<2", |
There was a problem hiding this comment.
it might be fine to go higher, but it caused a crash on the RTD compile so I've limited it for now. Be good to review these versions soon, since JWST has just moved up to supporting numpy v2
There was a problem hiding this comment.
wait no, I'm wrong, they're currently also pinned <2
low-sky
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hugely extends the level_match capabilities to also allow for simple 2D planes as well as just a constant offset. This seems to be necessary in some cases, for reasons currently unclear.
The type of fitting can be specified at each stage via the new parameters:
where the options are "level" (constant offset), and "level+slope" (plane)
When matching mosaic tiles, we need to define a reference image which we assume to be completely flat and edit other corrections relative to that. We either use the tile taken closest in time to the backgrounds (if they exist), or the one with maximal overlap between the tileset. As such, the lv2 step has been expanded slightly to include information on when the nearest background to the science observation was taken to make that easier
For now, this is a draft while we run through testing. Obvious test cases are NGC1792 and NGC253 where the level matching currently isn't great, but there may be others lurking