-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump web-vitals from 3.5.2 to 4.0.0 #745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for philanthropy-data-commons-viewer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a76b60c
to
34a5512
Compare
Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 3.5.2 to 4.0.0. - [Changelog](https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md) - [Commits](GoogleChrome/web-vitals@v3.5.2...v4.0.0) --- updated-dependencies: - dependency-name: web-vitals dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
34a5512
to
66d162b
Compare
Web Vitals v3 deprecated several methods and types, and v4 fully removed them. This commit adapts our code to the breaking changes. Note that the breaking removal of the `ReportHandler` type has been complained about[1] and may return in deprecated form[2], but we should go ahead and replace it anyway with the suggested inline typedef. [1] GoogleChrome/web-vitals#482 [2] GoogleChrome/web-vitals#483 PR #745 Bump web-vitals from 3.5.2 to 4.0.0
reefdog
added a commit
that referenced
this pull request
May 20, 2024
Google has deprecated the FIP metric and now promots INP[1]. This commit gets ahead of that deprecation. PR #745 Bump web-vitals from 3.5.2 to 4.0.0 [1] https://web.dev/articles/inp#inp-vs-fid
Google has deprecated the FIP metric and now promots INP[1]. This commit gets ahead of that deprecation. PR #745 Bump web-vitals from 3.5.2 to 4.0.0 [1] https://web.dev/articles/inp#inp-vs-fid
6f56023
to
cc7c3ad
Compare
@dependabot merge |
Dependabot tried to merge this PR, but received the following error from GitHub:
|
reefdog
approved these changes
May 20, 2024
@dependabot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps web-vitals from 3.5.2 to 4.0.0.
Changelog
Sourced from web-vitals's changelog.
Commits
9d1d10a
Release v4.0.006b459d
Merge branch 'v4'd145c11
Update v4 CHANGELOG and upgrading guide (#480)a12b628
Expose the target element in INP attribution (#479)14d3e1d
Save INP target early for when removed from DOM (#477)491cfb4
Release v4.0.0-rc.0c92caf6
Update CHANGELOGfd8b0c3
Small type clean up for v4 (#471)a6bed46
Better alternative for test flakiness on Firefox for FCP and LCP (#476)56e49c9
Allow reportAllChanges for LCP for late loaded script (#468)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)