Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): bump bitnami/node from 18.17.1-debian-11-r0 to 20.8.1-debian-11-r0 #562

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2023

Bumps bitnami/node from 18.17.1-debian-11-r0 to 20.8.1-debian-11-r0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps bitnami/node from 18.17.1-debian-11-r0 to 20.8.1-debian-11-r0.

---
updated-dependencies:
- dependency-name: bitnami/node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Oct 25, 2023
@dependabot dependabot bot requested a review from bickelj October 25, 2023 16:47
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f06e95) 95.24% compared to head (9d8fed7) 95.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   95.24%   95.24%           
=======================================
  Files          66       66           
  Lines         968      968           
  Branches      161      161           
=======================================
  Hits          922      922           
  Misses         43       43           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonaowen jasonaowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would update the version of Node.js from 18 to 20. Such an upgrade needs other changes as well, including to package.json and .node-version. Additionally, given the work in #622, we are planning to move away from Docker, so this becomes less relevant. Finally, CI does not use this Docker image, so the fact that tests pass should not give us any confidence that this would be safe to deploy.

@dependabot ignore this major version

@dependabot dependabot bot closed this Nov 28, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 28, 2023

OK, I won't notify you about version 20.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/docker/bitnami/node-20.8.1-debian-11-r0 branch November 28, 2023 20:19
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 28, 2023

OK, I won't notify you about version 20.x.x again, unless you re-open this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant