New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version restricted to 3 digits #2

Closed
igniteonline opened this Issue May 19, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@igniteonline
Copy link

igniteonline commented May 19, 2016

when calling validateVersion the installer expects exactly 3 digits, although ACF also releases updates with 4 digits as of version 5.3.8.1.
The regular expression to match against should be
$major_minor_patch = '/\A\d\.\d\.\d(\.\d)?\Z/';

@PhilippBaschke

This comment has been minimized.

Copy link
Owner

PhilippBaschke commented May 19, 2016

Good catch! I'll work on it. ☺️

PhilippBaschke added a commit that referenced this issue May 19, 2016

Allow exact versions with 3 or 4 digits
ACF PRO are sometimes released as 4 digit version numbers (e.g.
5.3.8.1). The validateVersion regex needs to be updated to account for
that scenario as well.

Fixes #2

PhilippBaschke added a commit that referenced this issue May 19, 2016

Allow exact versions with 3 or 4 digits (#3)
* Allow exact versions with 3 or 4 digits

ACF PRO are sometimes released as 4 digit version numbers (e.g.
5.3.8.1). The validateVersion regex needs to be updated to account for
that scenario as well.

Fixes #2

* Update README to reflect new valid versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment