#25 Login state is persisted on refresh #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmformenti
changed the title
jmformenti
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Apart from these changes we should take into account the following points:
- Delete the cookie when logging out.
- In Europe, when cookies are used on a website, permission must be requested from the user, I don't know in other countries. But for this point we can open a new track later.
|
updated in PR |
jmformenti
reviewed
Jan 15, 2024
frontend/service/oauth.service.js
Outdated
| const accessToken = decoded.accessToken | ||
| this.$store.commit('auth/login', { username, accessToken }) | ||
| } catch (err) { | ||
| // error logic here |
There was a problem hiding this comment.
What types of errors have you detected here? maybe could be interesting to put a console.error ?
jmformenti
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.