Improve editor #54
Draft
Improve editor #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phong13
reviewed
Mar 16, 2019
Scripts/Editor/BSoftBodyEditor.cs
Outdated
| SoftBody softBody = bSoftBodyTarget.GetCollisionObject() as SoftBody; | ||
| MeshFilter meshFilter = bSoftBodyTarget.GetComponent<MeshFilter>(); | ||
| // Transform trans = bSoftBodyTarget.transform; | ||
| Vector3[] vertices = meshFilter.sharedMesh.vertices; |
There was a problem hiding this comment.
This looks cool!
Can the vertices of the shared mesh be cached? Getting the vertices every editor frame update will generate a fair bit of garbage.
There was a problem hiding this comment.
That's definitely a good idea, but I am actually not using the vertices at all! I was thinking about using them, but I'm using the nodes instead.
Do you have any suggestions on other properties that should be available in the editor view?
There was a problem hiding this comment.
Are there some stiffness properties that could be edited this way? That would make adjusting the properties very intuitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for run-time editing of the mass of nodes of a SoftBody (https://twitter.com/i/status/1102674655872208897). Colours indicate their value.