Skip to content

Commit

Permalink
question / comment contextmanagers.py
Browse files Browse the repository at this point in the history
small notes in docstrings for clarification / questions (lines 117, 126, 140)
  • Loading branch information
kchall committed Mar 16, 2017
1 parent 01ae5f7 commit 80c115e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions corpustools/contextmanagers.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def get_frequency_base(self, gramsize = 1, halve_edges = False, probability = Fa
def get_phone_probs(self, gramsize = 1, probability = True, preserve_position = True, log_count = True):
"""
Generate (and cache) phonotactic probabilities for segments in
the Corpus.
the Corpus. # <- this doesn't seem right: surely it's just their probability (frequency) in the corpus, not their phonotactic probability? --KCH
Parameters
----------
Expand All @@ -123,7 +123,7 @@ def get_phone_probs(self, gramsize = 1, probability = True, preserve_position =
probability : boolean
If True, frequency counts will be normalized by total frequency,
defaults to False
defaults to False # <- doesn't it default to True as defined above? -- KCH
preserve_position : boolean
If True, segments will in different positions in the transcription
Expand All @@ -137,7 +137,7 @@ def get_phone_probs(self, gramsize = 1, probability = True, preserve_position =
-------
dict
Keys are segments (or sequences of segments) and values are
their phonotactic probability in the Corpus
their phonotactic probability in the Corpus # <- as above; KCH
"""
if (gramsize, preserve_position, log_count) not in self._freq_base:
freq_base = collections.defaultdict(float)
Expand Down

0 comments on commit 80c115e

Please sign in to comment.