Resize and reposition preview based on picture extend by frame #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi34
reviewed
May 20, 2024
|
No stale. Look at next days. |
andi34
force-pushed
the
feature/extend-preview
branch
3 times, most recently
from
3a95522
to
047e0f3
Compare
andi34
force-pushed
the
feature/extend-preview
branch
from
047e0f3
to
f0e1459
Compare
andi34
force-pushed
the
feature/extend-preview
branch
from
f0e1459
to
de02cc8
Compare
andi34
force-pushed
the
feature/extend-preview
branch
3 times, most recently
from
bce1b1f
to
b1fecdd
Compare
andi34
force-pushed
the
feature/extend-preview
branch
2 times, most recently
from
38ba197
to
43111c7
Compare
Change-Id: Iba87c10f4476b1cee1f6b5151594e12501db87c7
andi34
force-pushed
the
feature/extend-preview
branch
from
43111c7
to
29ee729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
In a previous feature I give the opportunity to the user to visualize the picture frame or the collage frame during the live preview.
At the time there wasn't the possibility to extend the picture by the frame setting up the percentages in left, top, right and bottom.
I created this feature to replicate what the user will see as a finished picture with frame applied during the live preview to better position himself during the countdown.
Is there anything you'd like reviewers to focus on?
I want the reviewers to focus in general on the code because it's been a long time since I coded the photobooth project