Dont send targets or cal images to UI #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #1198 |
mcm001
commented
Jan 27, 2024
photon-core/src/main/java/org/photonvision/common/configuration/PhotonConfiguration.java
Show resolved
Hide resolved
mcm001
commented
Jan 27, 2024
...on-core/src/main/java/org/photonvision/vision/calibration/CameraCalibrationCoefficients.java
Outdated
Show resolved
Hide resolved
Run lint Update UICameraCalibrationCoefficients.java Update RequestHandler.java asdf fdas
mcm001
force-pushed
the
dont-send-cal-snapshots
branch
from
04aa5af
to
6633496
Compare
srimanachanta
requested changes
Jan 28, 2024
There was a problem hiding this comment.
On systems with slow internet (FRC bandwidth limited radio) there are 1-3+ seconds of waiting for images to load which isn't ideal as people may think something isn't working. While the images are being fetched from the backend, the UI should show a loading symbol and a message as a placeholder until the fetch is complete and the correct image is shown.
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
srimanachanta
requested changes
Jan 29, 2024
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
photon-client/src/components/cameras/CameraCalibrationInfoCard.vue
Outdated
Show resolved
Hide resolved
srimanachanta
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces bandwidth requirements by being much lazier about how much calibration data is sent to the UI.
Trying to export cal or settings over robot wifi still sucks and is super slow. I think a modal to show this during calibration export makes sense?
also adds warnings on export time
