Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% test coverage #13

Closed
g105b opened this issue Feb 3, 2016 · 4 comments
Closed

100% test coverage #13

g105b opened this issue Feb 3, 2016 · 4 comments

Comments

@g105b
Copy link
Member

g105b commented Feb 3, 2016

The latest commits have seriously lowered the test coverage... Need to be pretty close to 100% before v1.0.0 release.

@g105b g105b modified the milestone: v1.0.0 Feb 9, 2016
@aguimaraes
Copy link
Contributor

aguimaraes commented May 16, 2016

PHPUnit can't find any class belonging to the phpgt\dom namespace when I try to run your tests.

The path is OK in composer.json, can you help me with the possible causes of this?

alvaro@alvaro-pc:~/Documents/dom$ phpunit
PHP Fatal error:  Trait 'phpgt\dom\LiveProperty' not found in /home/alvaro/Documents/dom/test/ExampleLiveProperty.php on line 5

@aguimaraes
Copy link
Contributor

PHPUnit 5.3.2
PHP 7.0.4

@g105b
Copy link
Member Author

g105b commented May 16, 2016

Thanks for the report @aguimaraes , I've created a separate issue for this at #30. Please run the PHP Unit supplied by Composer (vendor/bin/phpunit). I will look into what is causing a standalone version of PHPUnit to fail.

git clone https://github.com/phpgt/dom
cd dom
composer install
vendor/bin/phpunit

@aguimaraes
Copy link
Contributor

Works using the vendor dir binary.
Must be the version difference.

alvaro@alvaro-pc:~/Documents/dom$ phpunit --version
PHPUnit 5.3.2 by Sebastian Bergmann and contributors.

alvaro@alvaro-pc:~/Documents/dom$ vendor/bin/phpunit --version
PHPUnit 5.1.6 by Sebastian Bergmann and contributors.

Thank you.

@g105b g105b closed this as completed May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants