Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test data #4

Closed
1 of 2 tasks
g105b opened this issue Dec 2, 2017 · 0 comments
Closed
1 of 2 tasks

Improve test data #4

g105b opened this issue Dec 2, 2017 · 0 comments

Comments

@g105b
Copy link
Member

g105b commented Dec 2, 2017

Tests are quite slow to run, because there is so much random data generated in the PHPUnit dataProviders.

Hundreds of random input strings are generated in the unit tests, there are two improvements I can see:

  • It would be a better test to see input of varying length (very short, and very long)
  • There doesn't need to be as much random data generated, so the tests run quicker
@g105b g105b added this to the v1 milestone Dec 3, 2017
@g105b g105b changed the title Make random test input longer and shorter Improve test data Dec 7, 2017
@g105b g105b closed this as completed in de9ec67 Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant